geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

PB-871 : add debug UI and URL params to override URLs used by data integration team - #minor #1025

Closed pakb closed 2 weeks ago

pakb commented 1 month ago

Test link

cypress[bot] commented 1 month ago

web-mapviewer    Run #3135

Run Properties:  status check passed Passed #3135  •  git commit 5061ab6bbf: PB-871 : keep base URL config objects private
Project web-mapviewer
Branch Review feat-PB-871-debug-tools-for-url
Run status status check passed Passed #3135
Run duration 05m 29s
Commit git commit 5061ab6bbf: PB-871 : keep base URL config objects private
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎
ltclm commented 3 weeks ago

great, thank you @pakb one small question: when setting the api_url to http://localhost:9176 as here:

https://sys-map.int.bgdi.ch/preview/feat-pb-871-debug-tools-for-url/index.html#/map?lang=de&center=2609348.52,1236799.55&z=4.585&bgLayer=ch.swisstopo.pixelkarte-farbe&topic=ech&swisssearch=SWISSIMAGE+Zeitreise&layers=ch.swisstopo.swissimage-product@year=2017;ch.swisstopo.swissimage-product.metadata@year=2017@features=206028&featureInfo=default&timeSlider=2017&api_url=http://localhost:9176/

the identify request is done with the localhost url but the htmlpopup is still done by sys-api3.int.bgdi.ch.