search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

PB-788 : Mobile/tablet help menu section #1028

Closed pakb closed 2 days ago

pakb commented 1 month ago

With lang selector being transformed into an extra button of this new help section

Test link

cypress[bot] commented 1 month ago

web-mapviewer    Run #3277

Run Properties:  status check passed Passed #3277  •  git commit 50b316c9af: PB-788 : add a little CSS trick to circumvent iOS Safari bug
Project web-mapviewer
Branch Review fix-PB-788-help-menu-section
Run status status check passed Passed #3277
Run duration 04m 51s
Commit git commit 50b316c9af: PB-788 : add a little CSS trick to circumvent iOS Safari bug
Committer Pascal Barth
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎
pakb commented 1 week ago

no we didn't discuss that, but that might be a good idea.

pakb commented 1 week ago

I have not yet made a deep review, but I noticed the tooltips are no longer reactive to language change. If we switch from french to german (for example), the content of the tooltip remains in french.

That's already the case on map.geo.admin.ch and isn't a regression coming from the changes on this PR