search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

PB 773 clickable droplet search - #minor #1031

Closed ismailsunni closed 2 weeks ago

ismailsunni commented 3 weeks ago

New screenshot: image

Test link

cypress[bot] commented 3 weeks ago

web-mapviewer    Run #3126

Run Properties:  status check passed Passed #3126  •  git commit c482319a90: PB-773: Remove deselect callback since it's not used.
Project web-mapviewer
Branch Review pb-773-clickable-droplet-search
Run status status check passed Passed #3126
Run duration 04m 34s
Commit git commit c482319a90: PB-773: Remove deselect callback since it's not used.
Committer Ismail Sunni
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎
ismailsunni commented 3 weeks ago

So, in short: First use case: show the location pop up Second use case: remove the droplet and select the object (then automatically show the info box for the object)

Regarding the toggle behaviour, there is a ticket to remove the behaviour, and use can show both location popup and infobox (PB-859).

ismailsunni commented 2 weeks ago

hi @ltshb I have updated the approach. Now, when you click the pin, it will show the pop up location (as shown in the screenshot above).

I will implement the second use case in another PR, since the original issue is clicking on the droplet.

Thanks