search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
63 stars 11 forks source link

PB-980: use single OpenLayersWMSLayer for WMS group to reduce the number of GetMap request. #1114

Closed ismailsunni closed 3 weeks ago

ismailsunni commented 4 weeks ago

Test link

cypress[bot] commented 4 weeks ago

web-mapviewer    Run #3788

Run Properties:  status check passed Passed #3788  •  git commit 680db1d74e: PB-980: Simplify return of ExternalWMSLayer.
Project web-mapviewer
Branch Review pb-980-single-request-getmap
Run status status check passed Passed #3788
Run duration 05m 23s
Commit git commit 680db1d74e: PB-980: Simplify return of ExternalWMSLayer.
Committer Ismail Sunni
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎
ismailsunni commented 4 weeks ago

hi @ltkum thanks for pointing this one. After an investigation, it seems, it's a bug in the prod. If you check the opacity, it should be 0.75 as shown in this PR instance. In the prod instance, it's not.

If you check again, in prod, you can't update the transparency. It always show the same transparency. Meanwhile, in this PR instance, when you update the transparency, the layer transparency is also changing.

So, I conclude that this PR also fixes that transparency bug.

ismailsunni commented 3 weeks ago

per my discussion with @pakb , we will try to remove ExternalGroupOfLayers class and update ExternalWMSLayer to have a children