search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
63 stars 11 forks source link

PB-1028 : fix COG loading after rebase error #1126

Closed pakb closed 2 weeks ago

pakb commented 2 weeks ago

While working on the latest PR for PB-1028 I made some rebase mistake and didn't detect them before merging.

COG files were loaded entirely once again... So here's the fix, with some additional benefits.

I tried to simplify the FileAPI functions, the ones that load files (either through a simple GET or through service-proxy) It wasn't possible, with the addition of COG to the mix, to keep FileParser to decide to load content on its own, so I created a function that get the MIME type (and other relevant info on the file) so that each time we need to load a file, we can decide which way (of loading) we want to go (proxy or not proxy)

I will add a new E2E test for COG in the next PR

Test link

cypress[bot] commented 2 weeks ago

web-mapviewer    Run #3819

Run Properties:  status check passed Passed #3819  •  git commit 6272c17835: PB-1028 : fix COG loading after rebase error
Project web-mapviewer
Branch Review bug-PB-1028-adapt-cog-loading
Run status status check passed Passed #3819
Run duration 05m 08s
Commit git commit 6272c17835: PB-1028 : fix COG loading after rebase error
Committer Pascal Barth
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 212
View all changes introduced in this branch ↗︎