search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
63 stars 11 forks source link

PB-1260: handle legacy value 'voidLayer' #1153

Closed ltkum closed 1 day ago

ltkum commented 1 day ago

Issue: In the old mapviewer, it was possible to have the bgLayer parameter to equals 'voidLayer', which is equivalent to the current 'void' parameter. However, it caused issues where it displayed errors and refused to show the correct "layer".

Cause: we did not handle the parameter at all in the legacy parser.

Fix: when bgLayer is set to 'voidLayer' while navigating a legacy route, we handle it correctly and transform it to 'void'

Test link

cypress[bot] commented 1 day ago

web-mapviewer    Run #3952

Run Properties:  status check passed Passed #3952  •  git commit b04e016bac: PB-1260: handle legacy value 'voidLayer'
Project web-mapviewer
Branch Review fix-PB-1260-voidLayer-full-support
Run status status check passed Passed #3952
Run duration 05m 45s
Commit git commit b04e016bac: PB-1260: handle legacy value 'voidLayer'
Committer Martin Künzi
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎