geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

PB-786: Fix geolocation error management - #patch #996

Closed ltshb closed 2 months ago

ltshb commented 2 months ago

While using the geolocation you have time to times the Unknown error window that appears. This is due to the fact that the geolocation can return an error, but while using the app on the field I noticed that it happens sometimes just once and then everything seems to work fine. In this case the error windows is quite annoying as you have to close it and if it happened during the initial get current position you had to disable and re-enable the geolocation.

So now I improved the error management and do some automatic retries until 3 times if we are the get current position phase, while in the watcher phase the error is ignored unless it happens more that 3 times in a row.

Test link

cypress[bot] commented 2 months ago

Passing run #2944 ↗︎

0 211 21 0 Flakiness 0

Details:

PB-786: Fix geolocation error management
Project: web-mapviewer Commit: 7c9f06d3ae
Status: Passed Duration: 03:58 💡
Started: Jul 8, 2024 12:11 PM Ended: Jul 8, 2024 12:15 PM

Review all test suite changes for PR #996 ↗︎