geoalchemy / geoalchemy2

Geospatial extension to SQLAlchemy
http://geoalchemy-2.readthedocs.org
MIT License
637 stars 112 forks source link

Allow geometry_type to be None at the type level to match documentation #500

Closed logankaser closed 8 months ago

logankaser commented 8 months ago

Description

Allow geometry_type to be None at the type level to match documentation. Fixes a common type checking error when using geoalchemy

Checklist

This pull request is:

adrien-berchet commented 8 months ago

Hi @logankaser Thank you very much for this work! The other parameters of this function don't cause any issue? Because there are other parameters that are optional so I'm wondering.

logankaser commented 8 months ago

I think we just were not using the other arguments on my team, hopefully these types are accurate as I've not used those arguments.

adrien-berchet commented 8 months ago

I think we just were not using the other arguments on my team, hopefully these types are accurate as I've not used those arguments.

Ok, I see :) Thanks for the new change!

adrien-berchet commented 8 months ago

Thank you very much! I'm going to push a new release to make these change available.

adrien-berchet commented 7 months ago

The new release is available: https://pypi.org/project/GeoAlchemy2/0.14.7