search

geoarrow / deck.gl-layers

deck.gl layers for rendering GeoArrow data
MIT License
73 stars 6 forks source link

Feature Request: Add Geo Arrow Icon Layer #123

Open MMJ744 opened 2 months ago

MMJ744 commented 2 months ago

Could you create a layer wrapper for the Icon Layer

I've been using the GeoArrowScatterplotLayer but wanted more control over what the rendered points look like, e.g shape.

I've taken a look at the source code for the layers but I can't quite figure out what would be different when wrapping the icon layer. Any chance of this layer being added, or more guidance on how I might be able to create/contribute it myself.

Thanks :)

kylebarron commented 2 months ago

I think you included the wrong link.

In any case, it should largely be copy and paste from the ScatterplotLayer or PointCloudLayer (I'd probably point you to the PointCloudLayer for reference, because the IconLayer probably shouldn't support MultiPoint geometries), but you also need to include the extra parameters to pass the iconAtlas, iconMapping, etc to the upstream layer.

am2222 commented 2 weeks ago

@kylebarron can you please have a look at this PR (https://github.com/geoarrow/deck.gl-layers/pull/129)?