geoarrow / deck.gl-layers

deck.gl layers for rendering GeoArrow data
MIT License
85 stars 8 forks source link

feat(#123): added-iconlayer-support #129

Open am2222 opened 3 months ago

am2222 commented 3 months ago

I assume a multipoint support can also be added here. maybe in the next PR.

Any additional comments are welcomed. Thanks!

kylebarron commented 3 months ago

I haven't had time to organize it yet, but in theory development here might be moving to a semi-official deck.gl fork in https://github.com/visgl/deck.gl-community

am2222 commented 3 months ago

@kylebarron thanks! I have some more updates on this layer and would like to add them to this PR eventually!

But as part of moving to community layers repository! Is this something planned to happend per each geoarrow layer separately?

Or is the plan to transfer the entire set of the geoarrow layers there all at once?

kylebarron commented 3 months ago

But as part of moving to community layers repository! Is this something planned to happend per each geoarrow layer separately?

Or is the plan to transfer the entire set of the geoarrow layers there all at once?

It was already forked in https://github.com/visgl/deck.gl-community/pull/67 and the existing layers are all at https://github.com/visgl/deck.gl-community/tree/master/modules/arrow-layers. But I haven't had time to actually test using them in my code (in Lonboard), and no one else is working on this right now.

If you were interested, you could try out using the deck.gl-community version of arrow-layers in your project and check that it works the same.

am2222 commented 3 months ago

@kylebarron ok so I will check that version! So shall I open a PR for Icon layers in that repository once I checked them?

kylebarron commented 3 months ago

Yeah that sounds great