Open am2222 opened 3 months ago
I haven't had time to organize it yet, but in theory development here might be moving to a semi-official deck.gl fork in https://github.com/visgl/deck.gl-community
@kylebarron thanks! I have some more updates on this layer and would like to add them to this PR eventually!
But as part of moving to community layers repository! Is this something planned to happend per each geoarrow layer separately?
Or is the plan to transfer the entire set of the geoarrow layers there all at once?
But as part of moving to community layers repository! Is this something planned to happend per each geoarrow layer separately?
Or is the plan to transfer the entire set of the geoarrow layers there all at once?
It was already forked in https://github.com/visgl/deck.gl-community/pull/67 and the existing layers are all at https://github.com/visgl/deck.gl-community/tree/master/modules/arrow-layers. But I haven't had time to actually test using them in my code (in Lonboard), and no one else is working on this right now.
If you were interested, you could try out using the deck.gl-community
version of arrow-layers
in your project and check that it works the same.
@kylebarron ok so I will check that version! So shall I open a PR for Icon layers in that repository once I checked them?
Yeah that sounds great
iconAtlas
toiconAtlasConfig
. For some reasoniconAtlas
param is overwritten in the parent class. I assume it is due to the property type ofimage
and since it also acceptsstring
and this causes the overwritten. I am not very familiar with deckgl's layer param validations if you can guide me to fix it I can finish this PR.I assume a multipoint support can also be added here. maybe in the next PR.
Any additional comments are welcomed. Thanks!