geoarrow / deck.gl-layers

deck.gl layers for rendering GeoArrow data
MIT License
73 stars 6 forks source link

Support polygons with holes #37

Closed kylebarron closed 8 months ago

kylebarron commented 9 months ago

The SolidPolygonLayer mentions holeIndices, but it's not clear if that works with binary attributes as well.

kylebarron commented 9 months ago

image

For the record, it doesn't seem to crash on polygons with holes... it just renders the hole as well

kylebarron commented 8 months ago

Felix mentioned that the MVTLayer currently renders polygons with holes via the indices attribute.

https://github.com/visgl/deck.gl/blob/6e6b48b82aa498b957ac775db15e62523c0c6e45/modules/layers/src/geojson-layer/geojson-layer-props.ts#L123-L125

See also the triangles attribute in the output of geojsonToBinary: https://loaders.gl/docs/modules/gis/api-reference/geojson-to-binary#outputs

kylebarron commented 8 months ago

https://github.com/visgl/loaders.gl/blob/a52ce43b3a5dd3461344398f13de3efe4d93e684/modules/gis/src/lib/flat-geojson-to-binary.ts#L446-L453

Ok so things to note here: