search

geoarrow / geoarrow-python

Python implementation of the GeoArrow specification
http://geoarrow.org/geoarrow-python/
Apache License 2.0
65 stars 4 forks source link

chore: Remove outdated array methods #15

Closed paleolimbot closed 1 year ago

paleolimbot commented 1 year ago

..the existing extension array methods were outdated and have been superceeded by _compute functions that work on more things than just an array. Because pyarrow's ChunkedArray does not have type-specific methods, I think we want to encourage (e.g.) geoarrow.pyarrow.as_wkt(something) rather than something.as_wkt() because it's pretty easy to get something that is a ChunkedArray (e.g., by using __arrow_array__ protocol or pyarrow.array(), both of which might return either).

codecov[bot] commented 1 year ago

Codecov Report

Merging #15 (72c67ee) into main (77cce8d) will decrease coverage by 0.03%. Report is 1 commits behind head on main. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   94.55%   94.53%   -0.03%     
==========================================
  Files           9        9              
  Lines        1268     1245      -23     
==========================================
- Hits         1199     1177      -22     
+ Misses         69       68       -1
Files Coverage Δ
geoarrow-pyarrow/src/geoarrow/pyarrow/_array.py 89.28% <ø> (-1.09%) :arrow_down: