geoarrow / geoarrow-python

Python implementation of the GeoArrow specification
http://geoarrow.org/geoarrow-python/
Apache License 2.0
65 stars 4 forks source link

perf: Remove validation from `wrap_array()` #23

Closed paleolimbot closed 1 year ago

paleolimbot commented 1 year ago

This resulted in some unexpected performance characteristics and was not all that useful (since you could still have geometrically invalid data that happened to parse with validate=True). Because it was the default, it was pretty easy to get terrible performance and not know why (e.g., with geoarrow.pyarrow.io.read_pyogrio_table()).

codecov[bot] commented 1 year ago

Codecov Report

Merging #23 (dd563a6) into main (a59aae6) will decrease coverage by 0.31%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   94.56%   94.25%   -0.31%     
==========================================
  Files          10       10              
  Lines        1233     1219      -14     
==========================================
- Hits         1166     1149      -17     
- Misses         67       70       +3     
Files Coverage Δ
geoarrow-pyarrow/src/geoarrow/pyarrow/_compute.py 97.80% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/_kernel.py 94.04% <ø> (-3.63%) :arrow_down:
geoarrow-pyarrow/src/geoarrow/pyarrow/_type.py 95.49% <ø> (-0.22%) :arrow_down:
geoarrow-pyarrow/src/geoarrow/pyarrow/_array.py 89.28% <66.66%> (ø)