search

geoarrow / geoarrow-python

Python implementation of the GeoArrow specification
http://geoarrow.org/geoarrow-python/
Apache License 2.0
59 stars 3 forks source link

Rename `VectorType` to `GeometryExtensionType` #26

Closed paleolimbot closed 11 months ago

paleolimbot commented 11 months ago

...before anybody actually uses this!

Unfortunately, GeometryType is a no go because it's the enum name. It's a base class, so hopefully not an issue that it's more verbose.

codecov[bot] commented 11 months ago

Codecov Report

Merging #26 (2ef09a1) into main (76b19e6) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          10       10           
  Lines        1219     1219           
=======================================
  Hits         1149     1149           
  Misses         70       70
Files Coverage Δ
geoarrow-pandas/src/geoarrow/pandas/lib.py 93.50% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/__init__.py 72.72% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/_array.py 89.28% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/_compute.py 97.80% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/_kernel.py 94.04% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/_scalar.py 68.88% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/_type.py 95.49% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/dataset.py 99.53% <100.00%> (ø)
geoarrow-pyarrow/src/geoarrow/pyarrow/io.py 100.00% <ø> (ø)
kylebarron commented 11 months ago

you could always prepend Base onto the name of the base class too!