geoblacklight / geoblacklight

Discovery platform for GIS data.
http://geoblacklight.org
Other
143 stars 55 forks source link

Generating engine cart test app updates package.json #1569

Open eliotjordan opened 2 weeks ago

eliotjordan commented 2 weeks ago

It shouldn't touch the main repo package file.

Results of git diff ./package.json

 "dependencies": {
+    "@github/auto-complete-element": "^3.6.2",
     "@hotwired/stimulus": "^3.2.2",
     "@popperjs/core": "^2.11.8",
     "@samvera/clover-iiif": "^2.3.2",
+    "blacklight-frontend": "^7.38.0",
     "bootstrap": "^5.3.3",
     "esri-leaflet": "^3.0.12",
     "leaflet": "^1.9.4",
thatbudakguy commented 2 weeks ago

I think this might be related to things Blacklight does during its propshaft install generator. I don't know why this affects the outer package.json, though...

thatbudakguy commented 2 weeks ago

1539 adds these dependencies explicitly, so there won't be any changes once that is merged.

thatbudakguy commented 2 weeks ago

Going to close this since #1539 was merged, but it might be worth returning to since I don't fully understand the root cause.

eliotjordan commented 4 days ago

Reopening because it is still an issue.

thatbudakguy commented 4 days ago

Yeah, it still seems to alter the blacklight-frontend dependency. I think this is part of actions Blacklight takes during its generators, as noted above, but not sure what to do about it. I wonder if other BL8-based apps (Arclight?) also see this?