search

geoblacklight / geoblacklight

Discovery platform for GIS data.
http://geoblacklight.org
Other
144 stars 56 forks source link

Replace solr_wrapper with docker compose #1611

Closed eliotjordan closed 2 months ago

eliotjordan commented 2 months ago

Fully remove solr_wrapper and use compose for test and development.

thatbudakguy commented 2 months ago

What's the reasoning behind this? I know we've had some recent issues with solr_wrapper (incompatibility with newer solr versions?); is there more going on?

eliotjordan commented 2 months ago

As a community, there has been frustration with solr_wrapper for a long time. It's awkward to use and now we have a solr docker. Why not use it? I would much prefer a dockerized solr over solr_wrapper. It served a function, but technology has advanced. It's easy to add if implementers want to use it.

eliotjordan commented 2 months ago

Also, I'm working up a PR to move a lot of our fixtures services (WFS, WMS, IIIF) to containers. If that gets merged it would be nice to spin up all the development parts in one command.

ewlarson commented 2 months ago

With our CI test suite and PR pre-built packages already all-in on Docker, I'd like to have one technology path for standing the app up for development, code review, and testing.

Nothing wrong with SolrWrapper whatsoever, and I've really liked it for years, but moving to Docker is key to keeping the stack consistent here.

eliotjordan commented 2 months ago

I'll add that development experience for our local blacklight apps really improved once we moved to spinning up Solr with Lando (a convenience tool that uses docker). solr_wrapper is acceptable, but running with docker is definitely an improvement.