geoblacklight / geoblacklight_sidecar_images

Store local copies of remote imagery in GeoBlacklight
Apache License 2.0
4 stars 3 forks source link

Can't save image for a restricted scanned map without IIIF endpoint #17

Closed eliotjordan closed 4 years ago

eliotjordan commented 4 years ago

Can't save image for a restricted scanned map with no IIIF endpoint but with a thumbnail ref.

Saving service_url in the metadata hash

https://github.com/geoblacklight/geoblacklight_sidecar_images/blob/develop/app/services/geoblacklight_sidecar_images/image_service.rb#L56

can cause placeheld to be set to true

https://github.com/geoblacklight/geoblacklight_sidecar_images/blob/develop/app/services/geoblacklight_sidecar_images/image_service.rb#L194

when it should be false

https://github.com/geoblacklight/geoblacklight_sidecar_images/blob/develop/app/services/geoblacklight_sidecar_images/image_service.rb#L158

Solution is to remove service_url from the metadata.