search

geoblink / design-system

Collection of Vue components and Design Tokens used across Geoblink
https://design-system.geoblink.com/
MIT License
27 stars 2 forks source link

Feature/core 9496 calendar locked input #105

Closed dletran closed 2 years ago

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/geoblink/design-system/A2QX8s6VbRW3Va982cwLqhdYALN5
✅ Preview: https://design-system-git-feature-core-9496-calendar-lo-217b6d-geoblink.vercel.app

Navas23 commented 2 years ago

Good job, what happens if we set both new props as true?

dletran commented 2 years ago

Good job, what happens if we set both new props as true?

both controls would appear disabled although you'd probably be able to select endDate, it's not supposed to be used like that, do you think we should do something about it to prevent it or just leave it to the dev using it?

Navas23 commented 2 years ago

Good job, what happens if we set both new props as true?

both controls would appear disabled although you'd probably be able to select endDate, it's not supposed to be used like that, do you think we should do something about it to prevent it or just leave it to the dev using it?

I think we can live with it :ok_hand:

fofi commented 2 years ago

Good job, what happens if we set both new props as true?

both controls would appear disabled although you'd probably be able to select endDate, it's not supposed to be used like that, do you think we should do something about it to prevent it or just leave it to the dev using it?

I think we can live with it ok_hand

We could maybe check it on mount or something like that, just display a warn, but as you said, is not really important