geoblink / design-system

Collection of Vue components and Design Tokens used across Geoblink
https://design-system.geoblink.com/
MIT License
27 stars 2 forks source link

Feature/core 3958 tests for chart labels #113

Closed irmakyz closed 1 year ago

irmakyz commented 1 year ago

I tried to find a way to check the exact positions, however since it is wrapper i think there is no actual values for translations :/ do you have any idea how can i achieve it, i checked other files but in general they are based on values as well

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
design-system ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 1:40PM (UTC)
dletran commented 1 year ago

I tried to find a way to check the exact positions, however since it is wrapper i think there is no actual values for translations :/ do you have any idea how can i achieve it, i checked other files but in general they are based on values as well

maybe we can do something similar as you're doing to check the text value

  1. you get the label element
  2. you get the bar element for that label
  3. you check that the distance between both is the expected according to the config
irmakyz commented 1 year ago

I tried to find a way to check the exact positions, however since it is wrapper i think there is no actual values for translations :/ do you have any idea how can i achieve it, i checked other files but in general they are based on values as well

maybe we can do something similar as you're doing to check the text value

  1. you get the label element
  2. you get the bar element for that label
  3. you check that the distance between both is the expected according to the config

hmmm okiii, i will try, hope it will work

irmakyz commented 1 year ago

i added new tests and looking at comments rn, will let you know when it is ready to review again @Navas23 @dletran

irmakyz commented 1 year ago

it is ready to review again @Navas23 @dletran

Navas23 commented 1 year ago

Don't forget to update the readme and the version