rename classnames according to the bem notation

geoblink / design-system

Collection of Vue components and Design Tokens used across Geoblink

https://design-system.geoblink.com/

MIT License

27 stars 2 forks source link

rename classnames according to the bem notation #142

Closed irmakyz closed 8 months ago

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 10, 2024 1:01pm

irmakyz commented 9 months ago

This new classes are not following BEM notation. Check this and ask me if it's not clear https://getbem.com/naming/

Also this should not be a major change, IMO it should be a minor one

[x] fix classes according to BEM notation
[x] Change it as a minor change

irmakyz commented 9 months ago

i made some changes, i think now it is better, wdyt? @Navas23

Navas23 commented 9 months ago

Yeah it's better, but let's wait for the rest in order to decide