asanzdj commented 3 years ago

Jira task:

https://geoblink.atlassian.net/browse/CORE-7973

App client PR

https://bitbucket.org/geoblink/geoblink-app/pull-requests/6438

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/geoblink/design-system/o0e2pjbfe
✅ Preview: https://design-system-git-feature-core-7973-clean-up-test-conso-7981fe.geoblink.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #69 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         154      154           
  Lines        3402     3403    +1     
  Branches      278      279    +1     
=======================================
+ Hits         2904     2905    +1     
  Misses        428      428           
  Partials       70       70

Impacted Files	Coverage Δ
src/elements/GeoDropdown/GeoDropdown.vue	`90.42% <100.00%> (+0.10%)`	:arrow_up:
...ts/GeoSegmentedControl/GeoSegmentedControlItem.vue	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e580ef...7cc88ff. Read the comment docs.

asanzdj commented 3 years ago

I'm missing the changelog changes. Appart from that, have you tested possible side effects of this?

Before and after changing it I ran test in DS and all was right. I suppose this problem happens applying it into a real app, because I found the problem occurs when component is updating (on $nextTick) and maybe at that moment the DOM is not completely loaded.

geoblink / design-system

Feature/core 7973 clean up test console errors #69

Codecov Report