asanzdj commented 3 years ago

Jira task:

https://geoblink.atlassian.net/browse/CORE-8496

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/geoblink/design-system/80t1u3nmd
✅ Preview: https://design-system-git-feature-core-8496-fix-not-defined-pro-b1edb9.geoblink.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #76 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files         156      156           
  Lines        3462     3462           
  Branches      293      293           
=======================================
  Hits         2957     2957           
  Misses        433      433           
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5774981...7bf5219. Read the comment docs.

asanzdj commented 3 years ago

We do not use this prop in the app right? do we have some functionality related to this prop?

No, now you have to specify the button type (the prop name is type), this prop was never declared but used in the template.

geoblink / design-system

(fix) Removed outdated prop in geo-button #76

Codecov Report