search

geobtaa / geoblacklight_admin

MIT License
4 stars 2 forks source link

Incorrect messages in Multiple Download links uploads/deletes #41

Closed karenmajewicz closed 5 months ago

karenmajewicz commented 8 months ago

See https://github.com/geobtaa/metadata/issues/542

We are getting error messages when uploading or deleting CSVs for multiple downloads. This seems to occur when a record already has multiple downloads attached.

  1. If we try to upload additional links, it says Document Links could not be created.
  2. If we upload a file for deleting links, it says Download Links could not be destroyed.

However, when we look at the record, we see that these actions are successful.

ewlarson commented 7 months ago

FYI, the application code for Multiple Download Links and Institutional Access Links is almost identical. The same type of error will be thrown for Institutional Access Links, too.

karenmajewicz commented 7 months ago

Tested importing a CSV file to delete and it seemed to work. This was the message (extra word in there, but makes sense otherwise)

Screenshot 2024-03-01 at 7 04 14 PM
karenmajewicz commented 7 months ago

Tested importing new multiple downloads to dev, but it threw a Rails error. The links did import though.

ewlarson commented 7 months ago

^ Can you share the CSV file that tossed the error?

karenmajewicz commented 7 months ago

It was this one 05a-01_multiple-downloads.csv