geobtaa / geoportal

Big Ten Academic Alliance Geoportal
Other
10 stars 5 forks source link

Address BL v8 Deprecation Warnings #390

Open ewlarson opened 3 years ago

ewlarson commented 3 years ago

👊 Punch list of BL-associated deprecation warnings to review and/or resolve:

BL v8 / Deprecation warnings

Geoportal

GeoBlacklight

Blacklight

BL Plugins


Test Run Examples

DEPRECATION WARNING: Initializing a Blacklight::Configuration::ViewConfig implicitly (by calling split) is deprecated. Call it as split! or pass initialize arguments. (called from at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/geoblacklight-4.0.0.pre.alpha/lib/geoblacklight/engine.rb:14)

DEPRECATION WARNING: download_link_direct is deprecated and will be removed from a future release (Use download_link_file instead). (called from _sers_ewlarsonrbenv_versions_lib_rubygemsgems_geoblacklight___pre_alpha_app_views_catalogdownloads_primary_html_erb1527083626743696470_94020 at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/geoblacklight-4.0.0.pre.alpha/app/views/catalog/_downloads_primary.html.erb:11)

DEPRECATION WARNING: url_for_document is deprecated and will be removed from a future release (Use SearchState#url_for_document directly). (called from block (2 levels) in _app_views_admin_api_index_json_jbuilder__1977432876748114189_95680 at /Users/ewlarson/Rails/clients/b1g/geoportal/app/views/admin/api/index.json.jbuilder:15)

DEPRECATION WARNING: #index_presenter is deprecated; use #document_presenter instead. (called from block (3 levels) in _app_views_admin_api_index_json_jbuilder__1977432876748114189_95680 at /Users/ewlarson/Rails/clients/b1g/geoportal/app/views/admin/api/index.json.jbuilder:19)

DEPRECATION WARNING: facet_in_params? is deprecated and will be removed from blacklight 8.0. (called from block (6 levels) in _app_views_admin_api_index_json_jbuilder__1977432876748114189_95680 at /Users/ewlarson/Rails/clients/b1g/geoportal/app/views/admin/api/index.json.jbuilder:51)

DEPRECATION WARNING: search_fields is deprecated and will be removed from a future release (removed without replacement). (called from block in _app_views_admin_api_index_json_jbuilder__1977432876748114189_95680 at /Users/ewlarson/Rails/clients/b1g/geoportal/app/views/admin/api/index.json.jbuilder:65)

DEPRECATION WARNING: search_field_options_for_select is deprecated and will be removed from a future release (removed without replacement). (called from search_fields at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/blacklight-7.19.2/app/helpers/blacklight/configuration_helper_behavior.rb:25)

DEPRECATION WARNING: path_for_facet is deprecated and will be removed from blacklight 8.0. (called from block (6 levels) in _app_views_admin_api_advanced_search_facets_json_jbuilder___4509073980516577787_95780 at /Users/ewlarson/Rails/clients/b1g/geoportal/app/views/admin/api/advanced_search_facets.json.jbuilder:44)

DEPRECATION WARNING: render_hash_as_hidden_fields is deprecated and will be removed from a future release (Use Blacklight::HiddenSearchStateComponent instead). (called from block in _app_views_catalogsearch_form_htmlerb1057263852176976629_96060 at /Users/ewlarson/Rails/clients/b1g/geoportal/app/views/catalog/_search_form.html.erb:2)

DEPRECATION WARNING: render_facet_partials is deprecated and will be removed from blacklight 8.0. (called from render_facet_partials at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/blacklight-7.19.2/app/helpers/blacklight/facets_helper_behavior.rb:39)

DEPRECATION WARNING: Calling render_facet_partials without passing the response keyword is deprecated and will be removed in Blacklight 8.0.0. (called from _app_views_cataloghome_text_htmlerb3291878576855308253_96040 at /Users/ewlarson/Rails/clients/b1g/geoportal/app/views/catalog/_home_text.html.erb:61)

DEPRECATION WARNING: constraint_query_label is deprecated and will be removed from a future release (Moving to Blacklight::ConstraintsComponent). (called from block in render_constraints_query at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/blacklight-7.19.2/app/helpers/blacklight/render_constraints_helper_behavior.rb:56)

DEPRECATION WARNING: [] is deprecated and will be removed from a future release. (called from render_constraints_filters at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/blacklight_range_limit-7.0.0/lib/blacklight_range_limit/view_helper_override.rb:47)

DEPRECATION WARNING: Use SearchState#to_h instead of SearchState#to_unsafe_h. (called from normalize_params at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/blacklight-7.19.2/lib/blacklight/search_state.rb:34)

DEPRECATION WARNING: default_search_field is deprecated and will be removed from a future release (Use Blacklight::Configuration#default_search_field). (called from add_advanced_parse_q_to_solr at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/bundler/gems/blacklight_advanced_search-0a2ca7b6ef94/lib/blacklight_advanced_search/advanced_search_builder.rb:54)

DEPRECATION WARNING: facet_display_value is deprecated and will be removed from blacklight 8.0. (called from facet_display_value at /Users/ewlarson/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/blacklight-7.19.2/app/helpers/blacklight/facets_helper_behavior.rb:300)

ewlarson commented 3 years ago

GBL Fixes here: