search

geocaml / ocaml-geojson

A library for manipulating, creating and parsing GeoJSON
https://geocaml.github.io/ocaml-geojson
Other
38 stars 10 forks source link

Refactor GeoJson type checking #11

Closed streetCoderr closed 2 years ago

streetCoderr commented 2 years ago

Hi @patricoferris Please help me observe the changes I made and let me know where I can make corrections. Thank you Sir.

streetCoderr commented 2 years ago

Great @streetCoderr the changes look good to me!

I'll try to fix the CI so you can rebase and we can double-check all the tests are passing.

Also it looks like I mistakenly committed the index.js file for the benchmarks which I will also fix in the CI PR. Could you remove your edits to that file in this PR please and then this is probably ready to go? Thanks again!

Alright @patricoferris , I'm on it.

streetCoderr commented 2 years ago

Great @streetCoderr the changes look good to me! I'll try to fix the CI so you can rebase and we can double-check all the tests are passing. Also it looks like I mistakenly committed the index.js file for the benchmarks which I will also fix in the CI PR. Could you remove your edits to that file in this PR please and then this is probably ready to go? Thanks again!

Alright Sir @patricoferris , I'm on it.

Done.. Please check the commit above

patricoferris commented 2 years ago

Thanks @streetCoderr -- do you mind doing a quick rebase to pick up the changes I made to the CI please? Once the 4.13.X is green should be good to go :))

streetCoderr commented 2 years ago

Thanks @streetCoderr -- do you mind doing a quick rebase to pick up the changes I made to the CI please? Once the 4.13.X is green should be good to go :))

Alright, I'm on it @patricoferris

patricoferris commented 2 years ago

Brilliant, thanks ^^

streetCoderr commented 2 years ago

Brilliant, thanks ^^

Thank you @patricoferris. I appreciate your feedback😊