geocaml / ocaml-rtree

A pure OCaml implementation of R-Trees
BSD 3-Clause "New" or "Revised" License
26 stars 7 forks source link

Cube bounding box for 3 dimensions #29

Closed kushalpokharel closed 11 months ago

kushalpokharel commented 11 months ago

Related Issue:

17

Description

This PR adds the Cube as a bounding box that can act as an envelope in 3 dimensions. It also contains tests to ensure the correctness of the Cube bounding box.

patricoferris commented 11 months ago

@kushalpokharel I think some of these review comments look good to me, shall we incorporate them ?

kushalpokharel commented 11 months ago

@patricoferris I have incorporated those changes with the above commit, please review. sorry for the delayed response

patricoferris commented 11 months ago

Thanks LGTM :))