search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

Extend Geocode Earth provider from Pelias provider #1005

Closed jbelien closed 5 years ago

jbelien commented 5 years ago

Related to #1004 (waiting for it to be merged first)

jbelien commented 5 years ago

@atymic I think the GeocoderEarth provider is ready to be upgraded (using the Pelias provider). Could you review it ? :)

jbelien commented 5 years ago

There is no breaking changes so I guess we can release this as 1.1.0, right ?

Ping @Nyholm

Nyholm commented 5 years ago

If the Public API did not change than this is fine.

Why did we need to update all the cached test responses?

jbelien commented 5 years ago

Why did we need to update all the cached test responses?

It was indeed probably not necessary. Would you prefer me to revert it ?

Nyholm commented 5 years ago

Na, thats fine. I just wondered. If we have to rewrite all the tests it may be an indicator that we changed the behaviour.

jbelien commented 5 years ago

Just to be sure, I just checked. Update of the cached response was not necessary indeed.

jbelien commented 5 years ago

New release 1.1.0 is live : https://packagist.org/packages/geocoder-php/geocode-earth-provider 🎉