search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

Adding provider ipfinder #1015

Closed benemohamed closed 2 years ago

benemohamed commented 5 years ago

Hi Adding provider ipfinder.

jbelien commented 5 years ago

Hello,

Can you make sure your PR passes all the tests ? Thanks a lot !

jbelien commented 5 years ago

Could you also add some specific tests ? Check another IP provider to have "examples".

atymic commented 5 years ago

I'm a bit concerned that you made this PR without disclosing you affiliation with the provider (it seems you created it).

I can't even find the website searching for the company name "ipfinder"

benemohamed commented 5 years ago

@atymic the website https://ipfinder.io/

jbelien commented 3 years ago

@benemohamed Would you have time to finish this PR (and merge our master to fix the conflict) ? Thanks.

Chris53897 commented 2 years ago

Looks like the website https://ipfinder.io/ is down.

jbelien commented 2 years ago

Thanks for the notice @Chris53897, I guess we can close this PR then.