search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 516 forks source link

OpenRouteService provider #1026

Closed gaelg closed 4 years ago

gaelg commented 4 years ago

Hi, here's a provider for OpenRouteService, heavily based on the GeocodeEarth provider which uses the same backend tool: Pelias.

Openrouteservice is managed by University of Heidelberg. They say "Openrouteservice is free and will stay free - for everyone": https://openrouteservice.org/plans/

It's needed for a contribution to Drupal: https://www.drupal.org/project/geocoder/issues/3085549

Please forgive my mistakes, I'm not very used to GitHub contributions.

jbelien commented 4 years ago

Awesome! Thanks a lot @gaelg ! Really happy that my Pelias "provider" is spreading :P

I'll give your PR a look ASAP!

atymic commented 4 years ago

Are we good to go on this PR @jbelien?

jbelien commented 4 years ago

Seems good to be merged 👍 I'll take care of the merge and the release of the new provider in the next few days ; thanks a lot !

jbelien commented 4 years ago

I was planning to release it today but I miss one admin access to finish the process. I contacted @Nyholm. Stay tuned ! 👍

gaelg commented 4 years ago

@Nyholm any news?

gaelg commented 4 years ago

https://github.com/geocoder-php/openrouteservice-provider

atymic commented 4 years ago

cc @Nyholm

jbelien commented 4 years ago

New provider is released: https://packagist.org/packages/geocoder-php/openrouteservice-provider (thanks for the access @Nyholm)

@gaelg The build is currently failing, could you have a look at it ?

atymic commented 4 years ago

@jbelien the issue is you need to tag the new version of the Pelias provider https://github.com/geocoder-php/pelias-provider

(old version has root as protected, so the queries are failing because it can't set the correct root URL)

jbelien commented 4 years ago

@jbelien the issue is you need to tag the new version of the Pelias provider https://github.com/geocoder-php/pelias-provider

(old version has root as protected, so the queries are failing because it can't set the correct root URL)

Oh, right, I'll take care of that tonight! Thanks!

jbelien commented 4 years ago

@atymic You were right, I released the new version of Pelias provider and the OpenRouteService provider build is now okay! Thanks :)

atymic commented 4 years ago

No worries :)