search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 516 forks source link

Exception interface should extend Throwable interface #1027

Closed maxhelias closed 4 years ago

maxhelias commented 4 years ago

PhpStan warns of an error about this

124    PHPDoc tag @throws with type Geocoder\Exception\Exception is not subtype of Throwable

And this has no impact as each exception inherits from \Exception

maxhelias commented 4 years ago

friendly ping @Nyholm :)

jbelien commented 4 years ago

But we can just extend it as the minimum supported version in php 7.

@atymic What doy you mean by this ?

maxhelias commented 4 years ago

I think he means that it's the same thing as Guzzle PR but without managing compatibility because the minimum requirement is PHP 7 for Geocoder

jbelien commented 4 years ago

Oh okay, that makes sense! Then I don't see any reason not to merge this :)

maxhelias commented 4 years ago

@jbelien Can we move forward and merge it ?

maxhelias commented 4 years ago

Thanks @jbelien :)