Added IP2Location and IP2LocationBinary provider.

[ip2location]

Please consider adding IP2Location into your provider list.

Thanks.

[ip2location]

We have made the required changes. Thanks!

[jbelien]

cc @jbelien could you take a look as well?

I'll have a look this weekend 👍

[atymic]

I'll have a look this weekend 👍

Thanks, no rush. Good to have a few sets of eyes :)

[jbelien]

I was planning to release it today but I miss one admin access to finish the process. I contacted @Nyholm. Stay tuned ! 👍

[jbelien]

New providers are released (thanks for the access @Nyholm):

• https://packagist.org/packages/geocoder-php/ip2location-provider
• https://packagist.org/packages/geocoder-php/ip2location-binary-provider

@ip2location The build for IP2Location Binary is currently failing, could you have a look at it ?

[jbelien]

I also added the 2 new providers on the main README: https://github.com/geocoder-php/Geocoder#ip

[atymic]

@jbelien looks like it's because we didn't commit the bin file to the repo (it's a large blob file)

Should we skip the tests in CI, or commit the big file?

[jbelien]

@jbelien looks like it's because we didn't commit the bin file to the repo (it's a large blob file)

Should we skip the tests in CI, or commit the big file?

It shouldn't be an issue since the response are cached, isn't it ? 🤔

[atymic]

I don't think they are cached, since it doesn't make HTTP requests. AFAIK only those can be cached.

[jbelien]

Seems like we added the binary file for the MaxMindBinary Provider (see https://github.com/geocoder-php/Geocoder/tree/master/src/Provider/MaxMindBinary/Tests/fixtures) so I guess we should do the same here!