search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

ProviderCache: Add option to separate cache between providers #1045

Closed AntoineLemaire closed 1 year ago

AntoineLemaire commented 4 years ago

Fix #1044

AntoineLemaire commented 2 years ago

Hello! Any news regarding this topic? :)

jbelien commented 2 years ago

Hello @AntoineLemaire ,

Thank you for your contribution. It looks good to me. Could you add a test for this new feature ?

Thanks.

AntoineLemaire commented 2 years ago

@jbelien I've just added a test to verify that cacheKeys are differents :)

AntoineLemaire commented 1 year ago

@Nyholm ? 😢

Nyholm commented 1 year ago

I did a big cleanup. Closed anything without activity the last few months. (Without actually looking too much on the prs)

I’ll be happy to open this again. I also see that you were waiting for review.

AntoineLemaire commented 1 year ago

@Nyholm I'm actually using a fork in production because of that, it's true that I never force ping anyone here Who should I ping for review? @jbelien ?

Nyholm commented 1 year ago

Thank you