Drop support for PHP 7.0 and PHP 7.1 (End of life)

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.

https://geocoder-php.org

MIT License

3.95k stars 516 forks source link

Closed jbelien closed 4 years ago

jbelien commented 4 years ago

Close #1066

jbelien commented 4 years ago

Build fails on PHP 7.4 ! I'll check (and fix) it this weekend before merging this !

jbelien commented 4 years ago

Well, I'm a bit puzzled about why it fails on PHP 7.4.

I guess it's related to

Function ReflectionType::__toString() is deprecated

but I can replicate it using the same PHP version (7.4.7) and can't find where ReflectionType is used.

Any idea @Nyholm @atymic ? -- Found it!

jbelien commented 4 years ago

Okay, I think I found it ! It was caused by PHPUnit 6 ; I upgraded it to PHPUnit 7 !

jbelien commented 4 years ago

I like that we normalized the composer.json but it made things a bit hard to review.

Yes, sorry about that ! I should have made 2 separate PR ; thought about it "too late" :P

jbelien commented 4 years ago

Here is a summary of the changes (outside formatting/normalization):