search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

Azure Maps #1075

Closed langerapp closed 3 years ago

langerapp commented 4 years ago

Hi, this is my first contribution, looking for feedbacks :+1:

atymic commented 4 years ago

Thanks for the PR @max-langerman :) See comments on the review.

langerapp commented 4 years ago

Hi, Just pushed changes after code review. p.s. I didn't update README file yet

atymic commented 4 years ago

Thanks for making those changes :) Feel free to request a re-review once readme is complete.

jbelien commented 4 years ago

Also, don't forget to apply the style fixes (see https://github.styleci.io/analyses/d0eL0L) and add some tests (and the cached responses). Thanks!

langerapp commented 4 years ago

@atymic How do I request a re-review? I mean, there's a specific button I should press?

jbelien commented 4 years ago

@atymic How do I request a re-review? I mean, there's a specific button I should press?

You can click on the 🔄 button. image

There is still some stuff to fix though.

atymic commented 4 years ago

Looks like travis and styleci still need to be fixed though.

langerapp commented 4 years ago

Thanks for your feedback. I've added .travis.yml + followed your suggestions.

langerapp commented 4 years ago

I keep getting "Config Issue The 'short_array_syntax' fixer cannot be enabled again because it has already been enabled." Can you tell me how to fix it?

jbelien commented 4 years ago

I keep getting "Config Issue The 'short_array_syntax' fixer cannot be enabled again because it has already been enabled." Can you tell me how to fix it?

We fixed it in master branch, you just have to merge our master to your branch (see documentation if needed).

jbelien commented 3 years ago

Thanks a lot @max-langerman 👌