geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 517 forks source link

[ArcGISOnline] Updated Readme to clarify token creation/use. #1105

Closed wantell closed 3 years ago

wantell commented 3 years ago

To better clarify the update to the ArcGISOnline Provider I have updated the Readme as follows:

This was prompted by my proposed update to the Drupal Geocoder module in support of my previous update to the ArcGISOnline Provider. Since the token has a max lifetime of 14 days, the Drupal code stores the credentials for obtaining a token, and automatically gets a new token when the existing one has expired. However, this generated some confusion due to the token method requiring a token value while the Drupal UI is requesting values for client_id and client_secret (the credentials).

Please let me know if you need me to make any further changes to this documentation.

jbelien commented 3 years ago

Thanks @wantell 🎉