search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 517 forks source link

Expect a PSR-18 client instead of a PHP-HTTP client #1110

Closed JaZo closed 1 year ago

JaZo commented 3 years ago

Resolves #1076 Requires https://github.com/geocoder-php/provider-integration-tests/pull/18

N.B. It's a chicken and egg problem because in both pull requests the tests will fail because it needs changes from the other PR.

JaZo commented 3 years ago

I can't change the integration tests of the providers because that requires a change in provider-integration-tests, so I'll also create a PR for that and finish this PR after.

PavelVais commented 3 years ago

Is there any progress of this PR ? It should be done to support guzzle7.

norkunas commented 2 years ago

@JaZo are you willing to finish this? :)

JaZo commented 2 years ago

Sorry for the long silence from my end. Yes, I still like to finish this! I'll go ahead and create a PR for provider-integration-tests so I can finish this PR.

JaZo commented 2 years ago

I've opened https://github.com/geocoder-php/provider-integration-tests/pull/18 for the changes in the integration tests.

jbelien commented 1 year ago

@JaZo Could you let me know ALL the tags you created ?

You didn't create a tag with the correct semver number for a lot of the tags you created and I need to clean it!

See #1161