geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 517 forks source link

Clean wrong tag/release created by @JaZo #1161

Closed jbelien closed 1 year ago

jbelien commented 1 year ago

After #1110, I've updated all changelog files and was planning to create new releases. But while creating new releases I realized that some tags already have been created by @JaZo. Unfortuntately, a lot of those tags are wrong : he seems to have created a 4.3.0 tag for all providers instead of following the correct semver!

I'm currently deleting the wrong tags but it has already been updated on https://packagist.org/.

@Nyholm Could you give me the rights on "your" packages so I can deleted the tags that are wrong on Packagist ? Thanks.

To avoid this in the future I've added a tag protection rule on all the provider repositories.

Nyholm commented 1 year ago

It is updated!

jbelien commented 1 year ago

Cleaning is now complete! Thanks @Nyholm for the assistance. 😄

JaZo commented 1 year ago

I don't know how that happened and I'm really sorry about that! I for sure didn't create these tags manually 🤔 Do you have any idea how that could've happened so I can make sure it never happens again?

jbelien commented 1 year ago

To be honest, I'm not sure what happened. Since it's the first time it ever happened, I assumed you created those tags. Sorry for the wrong assumption. I investigated a bit more. It might be caused by a bug in Subtree split, the tool we use to split our main repository into sub-repositories. I've checked the settings and it shouldn't push the tags (see below) but maybe something went wrong there.

image

JaZo commented 1 year ago

Ahhh, an issue with subtree split sounds plausible, let's hope it won't happen again!