geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

Replace HTTPlug factories by PSR-17 #1184

Closed nicolas-grekas closed 9 months ago

nicolas-grekas commented 1 year ago

All interfaces of php-http/message-factory are now deprecated. This PR provides a way to move to PSR-17 instead.

nicolas-grekas commented 1 year ago

Failures will be fixed once 4.4 will be tagged.

norkunas commented 1 year ago

@jbelien could you review/merge this? :)

jbelien commented 1 year ago

Thanks for the review @Nyholm Good idea indeed to create a new major release so we can also remove getMessageFactory(). 👍

nicolas-grekas commented 1 year ago

Needs https://github.com/geocoder-php/provider-integration-tests/pull/20 before I can move forward.

jbelien commented 1 year ago

Needs geocoder-php/provider-integration-tests#20 before I can move forward.

Woops! Sorry, I've missed that one. Checking it now 👍

ker0x commented 1 year ago

Hello @nicolas-grekas @jbelien ! Is there any progress on this PR?

jbelien commented 1 year ago

Hello @nicolas-grekas @jbelien ! Is there any progress on this PR?

I've just merged https://github.com/geocoder-php/provider-integration-tests/pull/20 and created a new release ; @nicolas-grekas can now update this PR. 👍

nicolas-grekas commented 1 year ago

PR rebased and ready. The two failures are related to the subtree splitting and need v4.6.0 of the common-http package to be released.

Chris53897 commented 11 months ago

@jbelien Is there a planned release date for version 4.6 for https://github.com/geocoder-php/php-common-http

Stadly commented 11 months ago

Looking forward to this being released :)

ruudk commented 9 months ago

@Nyholm You are probably very busy, but do you know what is needed to move this PR forward? Thanks 💙

jbelien commented 9 months ago

@jbelien I am happy to merge.

Thanks a lot @Nyholm for taking care of it! 😄 Sorry last few months have been very busy. I've dismissed my review so it's not blocking.

Nyholm commented 9 months ago

No worries. That is how it is sometimes.

Let's move forward with this =)

Nyholm commented 9 months ago

Thank you for the PR and the reviews