Closed nicolas-grekas closed 9 months ago
Failures will be fixed once 4.4 will be tagged.
@jbelien could you review/merge this? :)
Thanks for the review @Nyholm
Good idea indeed to create a new major release so we can also remove getMessageFactory()
. 👍
Needs https://github.com/geocoder-php/provider-integration-tests/pull/20 before I can move forward.
Needs geocoder-php/provider-integration-tests#20 before I can move forward.
Woops! Sorry, I've missed that one. Checking it now 👍
Hello @nicolas-grekas @jbelien ! Is there any progress on this PR?
Hello @nicolas-grekas @jbelien ! Is there any progress on this PR?
I've just merged https://github.com/geocoder-php/provider-integration-tests/pull/20 and created a new release ; @nicolas-grekas can now update this PR. 👍
PR rebased and ready. The two failures are related to the subtree splitting and need v4.6.0 of the common-http package to be released.
@jbelien Is there a planned release date for version 4.6 for https://github.com/geocoder-php/php-common-http
Looking forward to this being released :)
@Nyholm You are probably very busy, but do you know what is needed to move this PR forward? Thanks 💙
@jbelien I am happy to merge.
Thanks a lot @Nyholm for taking care of it! 😄 Sorry last few months have been very busy. I've dismissed my review so it's not blocking.
No worries. That is how it is sometimes.
Let's move forward with this =)
Thank you for the PR and the reviews
All interfaces of
php-http/message-factory
are now deprecated. This PR provides a way to move to PSR-17 instead.