search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Prepare release of 5.0.0 for willdurand/geocoder #1209

Open Nyholm opened 11 months ago

Nyholm commented 11 months ago

Is there anything else we should add here?

https://github.com/geocoder-php/php-common/compare/4.6.0...master

jbelien commented 11 months ago

I'll investigate the checks that are failing on PHP 8.2 but the tests for BingMaps seems to fail only on PHP 8.3.

1) Geocoder\Provider\BingMaps\Tests\BingMapsTest::testGeocodeWithRealAddressReturnsMultipleResults unserialize(): Extra data starting at offset 3984 of 3985 bytes

Chris53897 commented 8 months ago

@jbelien I guess it was wrong all the time and just popped up with PHP 8.3. https://php.watch/versions/8.3/unserialize-E-WARNING

I did create a PR (see above) to solve this. I am not sure if this is the best way. But i could not figure out where the LINE Carriage (i guess) at the File-End is created in the first place.

jbelien commented 8 months ago

✅ We're back on track: #1220

Nyholm commented 1 month ago

I've rebased the PR.

@jbelien please merge if you think we are ready.