search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

tests: fix deprecation from PHPUnit #1217

Open Chris53897 opened 8 months ago

Chris53897 commented 8 months ago 
There was 1 warning:

1) Geocoder\Provider\GeoIP2\Tests\GeoIP2AdapterTest::testReaderResponseIsJsonEncoded
assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() instead.
jbelien commented 8 months ago

That breaks all "(low)" checks. I would wait until we upgrade to PHPUnit 10 before making that change.

Chris53897 commented 8 months ago

This is maybe solved by https://github.com/geocoder-php/Geocoder/pull/1218 with Raising minimum PHPUnit version to 9.6 (or 9.6.x)

Chris53897 commented 8 months ago

Bumping the minium PHPUnit version, solved this problem. But of course this is up to you, to wait until PHPUnit 10+.