search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Create provider for Google Maps Places API #711

Closed Nyholm closed 5 years ago

TerjeBr commented 6 years ago

Unfinished work on this can be found in #447

jbelien commented 6 years ago

Hello @TerjeBr ,

Would you have some time to work on the Google Maps Places provider (based on your PR #447) ?

Thanks 😃

TerjeBr commented 5 years ago

PR #447 was @gmauricio work. I had nothing to do with it. I just linked his work to this Issue.

jbelien commented 5 years ago

Oh, sorry about that ...

I forward the question to @gmauricio then : Would you have some time to work on the Google Maps Places provider (based on your PR #447) ? :)

atymic commented 5 years ago

Hmm, I wonder if we were going to implement https://github.com/geocoder-php/Geocoder/issues/942 if this is still required?

jbelien commented 5 years ago

Hmm, I wonder if we were going to implement #942 if this is still required?

It's a different API, so IMHO it should be a different provider!

atymic commented 5 years ago

Oh, my bad. Getting them confused, ignore me :P

atymic commented 5 years ago

I've created a PR in #980 😄