Geonames: Add countryInfo endpoint

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.

https://geocoder-php.org

MIT License

3.95k stars 519 forks source link

Geonames: Add countryInfo endpoint #730

Closed DaxServer closed 7 years ago

DaxServer commented 7 years ago

Endpoints:

[x] countryInfo

Finalize:

[x] Unit tests
[x] Rebase
[x] StyleCI fixes

Nyholm commented 7 years ago

Could you address the style fixes suggested by StyleCI?

DaxServer commented 7 years ago

Sure @Nyholm I'll update the style fixes and push tests.

Nyholm commented 7 years ago

Awesome. Looks good. Just add a test, changelog and make sue StyleCI is happy.

DaxServer commented 7 years ago

@Nyholm All the requested changes are implemented. Please review when you can and let me know if any other changes are needed (any stashing of the commits)!

Nyholm commented 7 years ago

I think this all looks good. Could you rebase on master to make sure travis is green before I merge?

DaxServer commented 7 years ago

@Nyholm This should be it!

Nyholm commented 7 years ago

Awesome. Thanks!