geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Address Number Lost #747

Closed afabros closed 7 years ago

afabros commented 7 years ago

For numbers outside USA, numbers are lost in the geocoder data. For numbers inside USA, numbers are intact.

ex. 3 street name, province, country

Nyholm commented 7 years ago

What provider are you using?

afabros commented 7 years ago

I'm using GeocoderLaravel -- I get intermittent result from Philippines data, sometimes with streetNumber others none. I have null in provider but the coordinates are correct.

screen shot 2017-07-21 at 15 50 08
afabros commented 7 years ago

process done: input '3 snapdragon street, cainta' to get the coordinates. data that came back has null streetNumber.

Nyholm commented 7 years ago

Sure, but what provider? Do you get data from google maps? Bing? Yandex? etc

What does the HTTP response from prover say? Does the street number exist there?

afabros commented 7 years ago

Not sure how to do that with the GeocoderLibrary through https://github.com/geocoder-php/Geocoder/pull/654. provider is always null on my end.

afabros commented 7 years ago

again for USA, provider is not null, both address i tested in the philippines, provider is null.

screen shot 2017-07-21 at 16 12 24
afabros commented 7 years ago

Tried again and I'm getting this as the provider, still null streetNumber.

screen shot 2017-07-21 at 16 17 10
Nyholm commented 7 years ago

I need you to debug this for me to have a chance to figure it out. Not just giving me results of your queries.

What versions are you running of the packages? compser show | grep geocoder You also have to find out if you are using GoogleMaps or BingMaps. I've seen both in your results.

When you know what provider do are using, you need to figure out if it is for all request to that provider or only for some.

afabros commented 7 years ago

Hard to test which provider because the library is throwing null or two providers.

I manually tested both. only BingMaps provided the correct streetNumber. The problem is not the parsing on your end but on the provider side -- streetNumber on other countries are not yet correctly mapped.

Thank you for your time.

Nyholm commented 7 years ago

Okey. As you say, then there is nothing we can do about this.

Thank you for the issue.