search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Document the cache provider #762

Closed Nyholm closed 5 years ago

Nyholm commented 7 years ago

There is nothing about that provider ATM.

Baachi commented 6 years ago

Do we still need this provider? We rely on the PSR7 standard and guzzle and httplug have already a caching mechanism built-in. So in my opinion we can deprecate this provider and rather document how migrate to the "new cache mechanism".

WDYT?

ruudk commented 6 years ago

I would keep it. Having a separate plugin that gets the Query object and then calculates the cache key is valuable. For example see https://github.com/geocoder-php/Geocoder/issues/882

atymic commented 5 years ago

PR open in #977