Geonames provider notice

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.

https://geocoder-php.org

MIT License

3.95k stars 519 forks source link

Closed kornrunner closed 7 years ago

kornrunner commented 7 years ago

I've submitted a https://github.com/geocoder-php/geonames-provider/pull/1 within geonames repo. Given geonames key seems to be missing sometimes from responses, and patch avoids the notice issued by PHP.

The change is simple, I'll be more than happy to change anything if required. Thank you!

Nyholm commented 7 years ago

That repo is read only. Please make you PR to this repo instead

kornrunner commented 7 years ago

Sure, thanks, it's in #783

Nyholm commented 7 years ago

Thanks!

kornrunner commented 7 years ago

Any chance of tagging this as a minor? Thanks!

Nyholm commented 7 years ago

4.1 is tagged. Thank you for the reminder.