search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

PHP version 7 forced in 3.3.2 #790

Closed tmaly1980 closed 6 years ago

tmaly1980 commented 7 years ago

So.... 3.3.1 of willdurand/geocoder works dandy in a php 5.6 environment. Did a fresh install after 3.3.2 was released and now it requires php7. From my understanding this is a serious no-no in versioning, that you should have renamed it 3.4 because sub-minor version changes should always be non-breaking. This is pretty much very breaking. Please fix your version tags!

Nyholm commented 7 years ago

Thank you for this issue. As far as packagist says, 3.3.4 requires php54. https://packagist.org/packages/willdurand/geocoder#v3.3.2

Also, this might be an interesting read: http://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html

Nyholm commented 6 years ago

Closing because of inactivity.

willdurand commented 6 years ago

@Nyholm how long do you usually wait? I would like to install Probot on this organization, how do you feel about that?

Nyholm commented 6 years ago

It depends on the issue. For unconfirmed bug reports or feature request I would be happy to wait years. But for bugs confirmed false I would not wait more than a month.

It also depends on when the author first got a response. If the first response has been taking 2 months I wouldn't close it a few weeks after that...

Short answer is: It depends.

Hm, I do not think I've seen Probot before. Sure, give it a try =) This organisation is very easy to maintain now when the major version has been released.