search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Improve Nominatim Provider #806

Closed jbelien closed 6 years ago

jbelien commented 6 years ago

Add following fields:

Close #805

Nyholm commented 6 years ago

Thank you. After a first review I think it looks good.

Could you fix the style errors and add some tests?

jbelien commented 6 years ago

Could you fix the style errors and add some tests?

Doing it right now :)

jbelien commented 6 years ago

Style errors are fixed.

I'm quite new with PHPUnit so it might take some time to write the tests ; I'll do my best :) What kind of tests do you want me to add ?

Nyholm commented 6 years ago

We just need some integration testing. Ie, write a test and verify the result. The HTTP response will be cached, so make sure to commit the cached file.

It is really just copy paste from existing tests.

I want a test that shows the result has a class, display name, attribution etc.

jbelien commented 6 years ago

Okay, I'll try to figure this out :P

jbelien commented 6 years ago

I think it's done :) Tell me if I forgot something.

jbelien commented 6 years ago

Happy new year ! 🎉

jbelien commented 6 years ago

Done ! :)