search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

Changes to common files for PR #840 #849

Closed TerjeBr closed 6 years ago

TerjeBr commented 6 years ago

I have made a separate PR for the minimum amount of changes to the common files to land PR #840

Hope this will be acceptable.

TerjeBr commented 6 years ago

@Nyholm said:

When I said:

Try you restrict yourself to not update the common objects. You may send another PR with these changes later.

I meant: Please update this PR so you do not change common objects. I did not mean: Make a new PR with changes in common to be merged before this one.

This PR only contains the absolute neccesary changes that we agreed on in #840 Sorry if that was not clear before.

I have complied with every requirement you put in #840 so I hope you can merge this soon. After this is merged (an tagged with a new version tag), #840 will be able to run all tests. Then you can merge #840.

Please tell me if there is anything in this PR that was not agreed upon in the conversation in #840