search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

add new provider for Algolia Places #854

Closed Fabex closed 6 years ago

Fabex commented 6 years ago

New Provider to use Algolia Places

TODO

Baachi commented 6 years ago

@Nyholm Looks good to me, can i merge them?

Nyholm commented 6 years ago

It does look good. But it still missing some tests, right?

jbelien commented 6 years ago

There is indeed no test yet in this PR. I think it's because of https://github.com/Fabex/geocoder-algolia-places-provider/pull/1

@Fabex @sheub Can you include your tests in this PR ? Thanks :)

Fabex commented 6 years ago

Hi @Nyholm Tests are finally done. Big thanks to @sheub for his work. I hope it's good for you

jbelien commented 6 years ago

Awesome ! Thanks a lot guys !

I'll have a look ASAP 👍