search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Use AbstractHttpProvider in FreeGeoIp #865

Closed Stadly closed 6 years ago

Stadly commented 6 years ago

Use getRequest and getParsedResponse from AbstractHttpProvider instead of duplicating code in FreeGeoIp. See https://github.com/geocoder-php/Geocoder/pull/864.

Stadly commented 6 years ago

It seems that the latest version of Geocoder is not used by all the Travis runs, so the tests fail since AbstractHttpProvider is not up to date. Seems weird, but can that be the case? Only 2 of 5 environments fail.

Nyholm commented 6 years ago

It looks good. I need to make a new release of the http-common-provider.

Stadly commented 6 years ago

Ok

Nyholm commented 6 years ago

You need to update composer.json for this provider to geocoder-php/common-http:^4.1

Stadly commented 6 years ago

Done. Didn't help Travis, though.